Skip to content

Conversation

@diemtvu
Copy link
Contributor

@diemtvu diemtvu commented Nov 21, 2017

These are based on features that already checked in to head, and should be available in v0.3

istio/istio#1232

@diemtvu
Copy link
Contributor Author

diemtvu commented Nov 21, 2017

/assign @wattli @myidpt

periodSeconds: 5
```
* _Can I access the Kubernetes API Server with Auth enabled?_
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* _How to disable Auth on clients to access the Kubernetes API Server (or any control services that don't have Istio sidecar)?_
(Require v0.3 or later) Edit the `mtlsExcludedServices` list in Istio config map to contain the fully-qualified name of the API server (and any other control services for that matter). The default value of `mtlsExcludedServices` already contains `kubernetes.default.svc.cluster.local`, which is the popular service name of the Kubernetes API server.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent by 2 spaces, like above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* _How to disable Auth on clients to access the Kubernetes API Server (or any control services that don't have Istio sidecar)?_
(Require v0.3 or later) Edit the `mtlsExcludedServices` list in Istio config map to contain the fully-qualified name of the API server (and any other control services for that matter). The default value of `mtlsExcludedServices` already contains `kubernetes.default.svc.cluster.local`, which is the popular service name of the Kubernetes API server.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popular service name -> default service name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@myidpt
Copy link

myidpt commented Nov 22, 2017

/lgtm
/approve

Copy link

@myidpt myidpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Diem.

@myidpt
Copy link

myidpt commented Nov 22, 2017

@ldemailly can you approve this? Thanks.

@ldemailly ldemailly merged commit 21e3497 into istio:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants