[collab-galley] Merge a few critical PRs from master to collab-galley #15649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor server.Args out to its own package. - Move all settings into Args struct. - Make handling of defaults in command-line uniform. - Minor code analysis fixes. * Add missing edit. * Fix lint errors * fix server_test.go * suppress lint check * Fix imports.
#15203) * Add a process package to pkg/server for tracking sub-component. - process.Host is a basic container of multiple sub-components. - process.Component is an interface to be implemented by sub-components. * Fix lint errors. * Accommodate CR feedback.
# Conflicts: # galley/pkg/server/server.go
istio-testing
added
size/XXL
|
@ozevren: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid, ozevren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
istio-testing
pushed a commit
that referenced
this pull request
Jul 30, 2019
* Introduce galley/pkg/config/resource (#14725) * Add pkg/config/resource * Fix lint issues. * Add pkg/config/collection (#14749) * Add pkg/config/collection * Remove commented out code. * Make go linter happy. * Fix CR comments. * Delete runaway file. * Add pkg/config/event (#14825) * Add pkg/config/schema for Galley config metadata (#14852) * Add pkg/config/schema pkg/config/schema contains the main metadata parser/data model for Galley. + Adds the ast, model, parser &validator for the metadata model. + Adds codegeneration tools for generating code artifacts: mainly for pulling in proto types, and having well-defined collection names. * Add more schema tests. * Fix lint errors. * [collab-galley] Add basic kubernetes file processing utilities (#14965) * Add pkg/config/util * Linter fix. * [collab-galley] Add pkg/config/meshcfg (#15044) * Add pkg/config/meshcfg * Simplify concurrency model * Move pkg/features/pilot to pilot/pkg/features. This cleans up the /pkg package, in preparation of multi-repo. * Add pkg/config/source/inmemory (#15100) * [collab-galley] Add K8s core type model and in-memory support. (#15112) * Add K8s core type model and in-memory support. * Fix linter issues * Accommodate CR feedback. * [collab-galley] Add Filesystem source support. (#15163) * Add Filesystem source support. * Fix lint errors. * [collab-galley] Introduce pkg/config/source/kube/apiserver (#15169) * Introduce pkg/config/source/kube/apiserver * Fix lint errors. * Handle no-informer case. * fix lint issues. * Accommodate CR feedback. * [collab-galley] Introduce the config processing engine (#15361) * Introduce pkg/config/processing * Remove monitoring code. * Streamline session code. * More Streamline session code. * Fixup remaining state updates. * Fix lint issues. * Add comments to runtime for better explanation. * Accommodate CR feedback. * Add event.MergeSources. * Add Source merging support. * Fix lint error. * Interim factory model. * Fix lint error * Rename combinedSources. * Deflake TestRuntime_MeshEvent_WhileRunning * Accommodate CR feedback. * fix lint error * fix test. * Streamline logging scopes. * Fix lint error. * Fix lint error. * Fix test. * Fix test. * fix lint issue * [collab-galley] Complete the new config processor (#15580) * Introducing pkg/config/processor - Basic changes before landing the processor code. - Add a event.NewFnTransform, that allows creating transformers from functions. - Add various utility methods in eventing code. - Add synchronization in Runtime to avoid missing initial events, due to timings. * Add basic metadata. * Add authpolicy and direct converters. * Add Ingress transform * Direct copy of transform code. * Transform servieceentry code to the new model. * Complete pkg/processor. * Fix lint errors * Fix lint errors & tests. * Accommodate feedback. * [collab-galley] Merge a few critical PRs from master to collab-galley (#15649) * Refactor server.Args out to its own package. (#15202) * Refactor server.Args out to its own package. - Move all settings into Args struct. - Make handling of defaults in command-line uniform. - Minor code analysis fixes. * Add missing edit. * Fix lint errors * fix server_test.go * suppress lint check * Fix imports. * Add a process package to galley/pkg/server for tracking sub-components (#15203) * Add a process package to pkg/server for tracking sub-component. - process.Host is a basic container of multiple sub-components. - process.Component is an interface to be implemented by sub-components. * Fix lint errors. * Accommodate CR feedback. * Componentize code by moving it into server/components. (#15227) # Conflicts: # galley/pkg/server/server.go * [collab-galley] Wire-up the new pipeline (flag protected, off by default) (#15651) * Wire-up the new processing pipeline. * Fix comment * Remove dashboard entries for defunct metricx. * Accommodate feedback. * Accommodate feedback. * Accommodate feedback. * Accommodate feedback. (#15661) * [collab-galley] CRD Discovery support (#15652) * Add CRD listening support to Galley API Server Source. With CRD support, Galley will discover CRDs dynamically and will listen to only available ones. If Galley detects a change to the CRDs, then it will restart its config processing pipeline. Also add missing metadata entries for legacy Mixer resources. * Accommodate CR feedback. * Fix a crash, where the wrong collection name is passed to a snapshot. (#15818) * Fix lint issues. * Fix Yaml lint issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straight-up cherry-pick merge into collab-galley branch.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure