Remove GODEBUG from pilot and mixer #16852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug/feature in golang 1.13 causes GODEBUG to output thousands of messages. Since we will release 1.4 off of 1.13, I think the best course of action is to turn this off by default. See istio#16635
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
|
How much do we lose by disabling this? Are Prometheus metrics sufficient at this point to identify memory/gc issues? |
Both components export all sorts of GC stats, so I don't think we lose too much here. They can always be added back - this is just changing the default. If we don't do this the entire log will look like That is from less than a second |
ayj
approved these changes
Sep 5, 2019
|
/retest |
1 similar comment
|
/retest |
|
I like this very much, it is too noisy before. |
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug/feature in golang 1.13 causes GODEBUG to output thousands of
messages. Since we will release 1.4 off of 1.13, I think the best course
of action is to turn this off by default.
See #16635
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure