Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use kiali 1.4 so it can pick up patches #17013

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Conversation

linsun
Copy link
Member

@linsun linsun commented Sep 11, 2019

Based on recommendation from kiali team and what we have done in 1.2.

[ ] Configuration Infrastructure
[ ] Docs
[x ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@linsun linsun requested a review from a team as a code owner September 11, 2019 14:09
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 11, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2019
@linsun linsun changed the title use 1.4 so it can pick up patches use kiali 1.4 so it can pick up patches Sep 11, 2019
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think using a pinned version is a better idea but given that 1) we clearly aren't good at keeping it update to date and 2) we had it this way before, this seems fine. Thanks!

@jmazzitelli
Copy link
Member

@istio-testing
Copy link
Collaborator

@linsun: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pilot-multicluster-e2e_istio 751aa41 link /test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 6cfdfee into istio:master Sep 11, 2019
@clyang82
Copy link
Member

i think using a pinned version is a better idea but given that 1) we clearly aren't good at keeping it update to date and 2) we had it this way before, this seems fine. Thanks!

I think using a pinned version may leads the version we are testing in the release is different from the version user is using. That may have bug that we cannot cover in our release. Anyway, I think we should switch to kiali operator to leverage the kiali's experts for that.

howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants