-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use kiali 1.4 so it can pick up patches #17013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think using a pinned version is a better idea but given that 1) we clearly aren't good at keeping it update to date and 2) we had it this way before, this seems fine. Thanks!
Yes, using just vX.Y (as opposed to vX.Y.Z) is how we've been doing it since Istio 1.1 and 1.2: https://github.com/istio/istio/blob/release-1.1/install/kubernetes/helm/istio/charts/kiali/values.yaml#L7 |
@linsun: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I think using a pinned version may leads the version we are testing in the release is different from the version user is using. That may have bug that we cannot cover in our release. Anyway, I think we should switch to kiali operator to leverage the kiali's experts for that. |
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Based on recommendation from kiali team and what we have done in 1.2.
[ ] Configuration Infrastructure
[ ] Docs
[x ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure