Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests need to trigger once a PR is approved or at least once requested through build comment #433

Closed
ldemailly opened this issue Jun 24, 2017 · 3 comments
Closed

tests need to trigger once a PR is approved or at least once requested through build comment #433

ldemailly opened this issue Jun 24, 2017 · 3 comments
Assignees
@sebastienvas
Milestone
0.2

Comments

@ldemailly
Copy link
Contributor

ldemailly commented Jun 24, 2017 •
edited
Loading

Example : #381

Skipping [#381 Kubernetes RBAC - Allow ingress to read secrets for TLS ingresses] because of user restriction (user - GHUser@3dbb042[login=lachie83,location=,blog=,email=,name=,company=,followers=0,following=0,url=https://api.github.com/users/lachie83,id=6912984])

same as istio/istio.io#308
@ldemailly ldemailly added this to the Istio 0.2 milestone Jun 24, 2017
@ldemailly
Copy link
Contributor Author

I know this may change with prow but it's blocking

@sebastienvas
Copy link
Contributor

sebastienvas commented Jun 26, 2017 •
edited
Loading

duplicate of istio/istio.io#308

@ldemailly
Copy link
Contributor Author

I opened the other one earlier but it was in the wrong component (web) while it applies all across istio but sure

mandarjog pushed a commit to mandarjog/istio that referenced this issue Oct 30, 2017
@geeknoid
Fix another bug in the Quota method. (istio#433)
ed3648c 
Given the current config, the quota method can be invoked from the mixc command
with:

   bazel-bin/cmd/client/mixc quota --amount 1 -name RequestCount
Former-commit-id: f7447504168dcf670fcac6cce0232575915fbad6
mandarjog pushed a commit that referenced this issue Oct 31, 2017
@geeknoid
Fix another bug in the Quota method. (#433)
69b1135 
Given the current config, the quota method can be invoked from the mixc command
with:

   bazel-bin/cmd/client/mixc quota --amount 1 -name RequestCount
Former-commit-id: daa9124e6828ec7cd5e354831fcfbea526afe682
guptasu pushed a commit to guptasu/istio that referenced this issue Jun 11, 2018
@geeknoid
Fix comment that was being interpreted as a markdown link rather than…
b6cdb7b 
… a regex string. (istio#433)
kyessenov pushed a commit to kyessenov/istio that referenced this issue Aug 13, 2018
@lizan @rshriram
Use per request AsyncClient (istio#433)
933b1c3
kyessenov pushed a commit to kyessenov/istio that referenced this issue Aug 13, 2018
@istio-merge-robot
Update_Dependencies (istio#433)
a08d675 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
howardjohn added a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@howardjohn @istio-testing
Backport changes (istio#433)
d14e006 
* istio#16223

* istio#16272

* istio#16187

* istio#16466

* istio#16634

* istio#16594

* istio#16666

* istio#16483

* istio#16820

* istio#16842

* istio#16852

* istio#16835

* istio#16863

* istio#16892

* istio#16991

* istio#16957

* istio#17013

* istio#17134

* istio#17155

* istio#17235

* istio#17342

* istio#17477

* istio#17615

* istio#17334

* istio#17708

* istio#17737

* Fix injection template

* Fix quoting

* Fix test values

* Add accidentally deleted affinity
howardjohn pushed a commit to howardjohn/istio that referenced this issue Jan 12, 2020
@elfinhe @istio-testing
Add upgrade short description in ARCHITECTURE. (istio#433)
a426860 
* Add upgrade section in ARCHITECTURE.

* Polish the description.

* Shorten the description of upgrade.

* Minor
danehans pushed a commit to danehans/istio that referenced this issue Nov 2, 2021
@mathetake
Delete deprecated env (istio#433)
6b63e3d 
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
libesz pushed a commit to libesz/istio that referenced this issue Nov 11, 2021
@dgn
MAISTRA-2639 Fix multi-root support (istio#433)
8a3eb2c
antonioberben pushed a commit to antonioberben/istio that referenced this issue Jan 29, 2024
@mehta-ankit
Merge pull request istio#433 from gburton1/upgradeKafka19_2
57487fa 
jaeger: upgrade Kafka chart dependency from 18.x to 19.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastienvas sebastienvas

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@ldemailly @sebastienvas