Use health endpoint for Grafana readiness probe #16634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we used the login page, which returns 25kb of data. This will cause the probe to fail in Kubernetes 1.16+ (kubernetes/kubernetes#76518), which will limit to 10kb. This change mirrors the official Grafana charts readiness probe: https://github.com/helm/charts/blob/master/stable/grafana/values.yaml#L18-L21
howardjohn
requested review from
costinm,
linsun,
mandarjog,
morvencao,
ostromart and
sdake
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
|
Part of #16632 |
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
morvencao
approved these changes
Aug 29, 2019
|
In response to a cherrypick label: new pull request created: #16651 |
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we used the login page, which returns 25kb of data.
This will cause the probe to fail in Kubernetes 1.16+
(kubernetes/kubernetes#76518), which will limit
to 10kb.
This change mirrors the official Grafana charts readiness probe:
https://github.com/helm/charts/blob/master/stable/grafana/values.yaml#L18-L21
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure