Fixes to gateway template environment variables #16957
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
| @@ -1,18 +1,16 @@ | |||
| {{- range $key, $spec := .Values }} | |||
| {{- if ne $key "enabled" }} | |||
| {{- if $spec.enabled }} | |||
|
|
|||
| {{- $labels := dict "release" $.Release.Name "chart" (include "gateway.chart" $) "heritage" $.Release.Service }} | |||
| {{- $labels = merge $labels $spec.labels }} | |||
There was a problem hiding this comment.
There is an helm issue that complains the = here, which has been fixed from helm v2.13.0, see: helm/helm#4987
istio/istio is still using helm v2.10.0, isn't it?
There was a problem hiding this comment.
Ahh thanks! thats why it worked locally then.
We advertise helm 2.10 support so probably need to find an even dirtier hack to accomplish this
|
/test unit-tests_istio |
|
/retest |
|
/cherrypick release-1.3
…On Tue, Sep 10, 2019, 7:20 PM Morven Cao ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16957?email_source=notifications&email_token=AAEYGXJTUGFXSCCPKGZRVRLQJBIWLA5CNFSM4IVBZ6UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEKAKOA#pullrequestreview-286524728>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEYGXNZK4JHUKVLCZPV2HDQJBIWLANCNFSM4IVBZ6UA>
.
|
|
@howardjohn: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@howardjohn: new pull request created: #16995 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Fixes #16945