cleanup remote secrets when the cluster's discovery is not registered #18724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
ayj
added
cherrypick/release-1.4
and removed
size/S
istio-testing
added
the
size/S
|
/test pilot-multicluster-e2e_istio |
esnible
approved these changes
Nov 7, 2019
|
/test integ-pilot-k8s-tests_istio |
|
/retest |
|
/test lint_istio |
…ecrets-in-non-joined-cluster
|
/test integ-security-k8s-tests_istio |
|
/retest |
|
/test integ-security-k8s-tests_istio |
1 similar comment
|
/test integ-security-k8s-tests_istio |
|
In response to a cherrypick label: new pull request created: #18792 |
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
…istio#18724) * cleanup remote secrets when the cluster's discovery is not registered * fix race * switch back to istio-reader-service-account to match latest charts * use context instead of cluster in mesh description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.