Skip to content

Conversation

@ramaraochavali
Copy link
Contributor

Fixes the test and reverts the revert #25473
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali ramaraochavali requested a review from a team as a code owner July 14, 2020 05:19
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 14, 2020
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2020
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, what happened

@istio-testing istio-testing merged commit 05552aa into istio:master Jul 14, 2020
@ramaraochavali ramaraochavali deleted the fix/optimize_sni_hosts branch July 14, 2020 07:32
@ramaraochavali
Copy link
Contributor Author

Because of test infra issues #25463 - tests were incorrectly passed while there was a test issue in the original PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants