Fix description for istioctl verify-install #26139
Conversation
jwendell
added
release-notes-none
googlebot
added
the
cla: yes
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/S
istioctl/pkg/install/verify.go
Outdated
There was a problem hiding this comment.
Is this still correct without passing any param?
I'm getting this with latest master code base.
$ go run "${GOPATH}"/src/istio.io/istio/istioctl/cmd/istioctl/main.go verify-install
Error: could not load IstioOperator from cluster: control plane revision "" not found. Use --filename
exit status 1
There was a problem hiding this comment.
Yes, I'm getting the same. That's what motivated this PR. The description is outdated.
See #24068 (comment) and #23087 (comment)
There was a problem hiding this comment.
Ok, I see. Can we clarify the msg? Via Istio operator, does it mean server side operator or istioctl? Do we need to specify istio operator here?
|
cc @irisdingbj |
|
cc @esnible |
|
It changed in 1.6 :/ |
ericvn
dismissed
their stale review
I didn't find anything in the doc that really discussed this outside the reference docs. This also was removed in 1.6, so not sure if it's appropriate to add a release note in 1.7.
|
lgtm Yep, behaviour changed for this command in 1.6 so I will agree for this pr. But I want @esnible to confirm as he made this changes. |
|
In response to a cherrypick label: new pull request created: #26359 |
8 participants
Closes #24068.