Fix gen-eastwest-gateway.sh for ambient multi-cluster #57289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently ignores the --network parameter passed to the script and just hardcodes "network-1" which does not seem to result in the correct gatway config. Fixing the script since it's referenced from the docs we are creating for ambient multicluster. Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
istio-policy-bot
added
area/ambient
|
😊 Welcome @krinkinmu! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
keithmattix
approved these changes
Aug 7, 2025
keithmattix
added
the
release-notes-none
|
/retest |
|
@krinkinmu: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
keithmattix
added
the
cherrypick/release-1.27
|
In response to a cherrypick label: new pull request created: #57292 |
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: Filter out invalid certs. (istio#56830) Use xxhash when hasing Auth policy (istio#57205) Automator: update proxy@master in istio/istio@master (istio#57314) Automator: update proxy@master in istio/istio@master (istio#57310) Automator: update proxy@master in istio/istio@master (istio#57277) remove unused arg (istio#57304) ambient: WorkloadEntry supports a Service with a target port number (istio#57020) Automator: update ztunnel@master in istio/istio@master (istio#57296) Handle deadlock between CNI startup and plugin (istio#56972) Fix gen-eastwest-gateway.sh for ambient multi-cluster (istio#57289) Automator: update common-files@master in istio/istio@master (istio#57286) Check all workloads when deciding whether to send to EW gateway (istio#57288) Automator: update istio/client-go@master dependency in istio/istio@master (istio#57287) Finish zt hbone test (istio#57268) istioctl admin log: update the usage (istio#57273) cacerts file watcher bug (istio#57271) Automator: update proxy@master in istio/istio@master (istio#57267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
It currently ignores the --network parameter passed to the script and just hardcodes "network-1" which does not seem to result in the correct gatway config.
Fixing the script since it's referenced from the docs we are creating for ambient multicluster.
+cc @keithmattix @Stevenjin8 @jaellio @therealmitchconnors