Skip to content

Conversation

@kyessenov
Copy link
Contributor

Signed-off-by: Kuat Yessenov kuat@google.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov requested a review from a team September 15, 2022 16:12
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2022
@kyessenov
Copy link
Contributor Author

/retest

@kyessenov kyessenov closed this Sep 15, 2022
@kyessenov kyessenov reopened this Sep 15, 2022
@kyessenov kyessenov closed this Sep 15, 2022
@kyessenov kyessenov reopened this Sep 15, 2022
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Contributor Author

The issue is not in base envoy, likely another painful Wasm bug or the extension itself.

@kyessenov kyessenov closed this Sep 16, 2022
@kyessenov kyessenov reopened this Sep 16, 2022
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov closed this Sep 19, 2022
@kyessenov kyessenov reopened this Sep 19, 2022
@kyessenov kyessenov closed this Sep 19, 2022
@kyessenov kyessenov reopened this Sep 19, 2022
@istio-testing
Copy link
Collaborator

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test_proxy 69e521f link true /test test
test-tsan_proxy 69e521f link true /test test-tsan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov kyessenov closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants