fix: fix required bug

isuke · isuke · commit 56f084ae7c91 · 2018-02-09T23:09:48.000+09:00
diff --git a/git-consistent b/git-consistent
@@ -111,7 +111,7 @@ const replaceTerm = (program, template, definition, term) => {
     if (_.isEmpty(value)) value = input(term, definition)
     // TODO: do loop if required and value is empty
   } else {
-    if (_.isEmpty(value)) throw new Error(`${term} is required.`)
+    if (_.isEmpty(value) && definition.required) throw new Error(`${term} is required.`)
   }
 
   return _.replace(template, `<${term}>`, value)

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ const replaceTerm = (program, template, definition, term) => {`
`111`	`111`	`if (_.isEmpty(value)) value = input(term, definition)`
`112`	`112`	`// TODO: do loop if required and value is empty`
`113`	`113`	`} else {`
`114`		- if (_.isEmpty(value)) throw new Error(`${term} is required.`)
	`114`	+ if (_.isEmpty(value) && definition.required) throw new Error(`${term} is required.`)
`115`	`115`	`}`
`116`	`116`
`117`	`117`	return _.replace(template, `<${term}>`, value)