Skip to content

60 integrate prettify check into cicd #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 5, 2024
Merged

60 integrate prettify check into cicd #61

merged 13 commits into from
Jun 5, 2024

Conversation

@langehm
Copy link
Contributor

@langehm langehm commented May 8, 2024

Issues #60

@langehm langehm linked an issue May 8, 2024 that may be closed by this pull request
Integrate prettify check into ci/cd #60
Closed
@langehm langehm changed the title 60 integrate prettify check into cicd ✨ 60 integrate prettify check into cicd May 8, 2024
@langehm langehm changed the title ✨ 60 integrate prettify check into cicd 60 integrate prettify check into cicd May 8, 2024
@langehm langehm marked this pull request as draft May 8, 2024 13:00
@FabianWilms FabianWilms changed the base branch from main to beta May 10, 2024 08:45
langehm added a commit that referenced this pull request May 29, 2024
@langehm
🎨 removed all icons except two #61
dbe39b6
@langehm langehm marked this pull request as ready for review June 5, 2024 08:45
@langehm langehm requested a review from FabianWilms June 5, 2024 08:45
@langehm langehm self-assigned this Jun 5, 2024
FabianWilms
FabianWilms previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@FabianWilms FabianWilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@langehm langehm requested a review from FabianWilms June 5, 2024 10:55
@langehm
Copy link
Contributor Author

langehm commented Jun 5, 2024

Upon merging beta into this branch, some linting erros occured - therefore the new commit

@langehm
Copy link
Contributor Author

langehm commented Jun 5, 2024 •
edited
Loading

@FabianWilms Should we exclude the dist and storybook folder from eslint? The files inside are generated anyway and out of our controll

@FabianWilms
Copy link
Member

FabianWilms commented Jun 5, 2024

@FabianWilms Should we exclude the dist and storybook folder from eslint? The files inside are generated anyway and out of our controll

eslint can ignore the same files as in .gitignore - and dist and storybook-static are already in it.

--ignore-path .gitignore

@langehm langehm merged commit 8c3a85d into beta Jun 5, 2024
@langehm langehm deleted the 60-integrate-prettify-check-into-cicd branch June 5, 2024 12:23
@github-actions
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 1.8.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianWilms FabianWilms FabianWilms approved these changes

Assignees

@langehm langehm

Labels

released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate prettify check into ci/cd

3 participants

@langehm @FabianWilms