Skip to content

Conversation

@langehm
Copy link
Contributor

@langehm langehm commented May 24, 2024

Issues #41

@langehm langehm linked an issue May 24, 2024 that may be closed by this pull request
@langehm langehm self-assigned this May 24, 2024
@langehm langehm requested a review from FabianWilms May 24, 2024 08:58
@langehm langehm marked this pull request as ready for review May 24, 2024 08:58
@langehm
Copy link
Contributor Author

langehm commented May 24, 2024

We should build a wrapper component for icons.

@langehm langehm changed the title 41 sparkles adding business hours component ✨ 41 sparkles adding business hours component May 24, 2024
@langehm
Copy link
Contributor Author

langehm commented May 24, 2024

grafik

just a preview ...

@langehm
Copy link
Contributor Author

langehm commented May 24, 2024

The JS-Toggle does not work from the patternlab (missing the scripts). Currently, the toggle is done via a simple function. This can be reverted easily as soon as the scripts are imported into the project.

@FabianWilms
Copy link
Member

We should build a wrapper component for icons.

#95

@FabianWilms
Copy link
Member

The JS-Toggle does not work from the patternlab (missing the scripts). Currently, the toggle is done via a simple function. This can be reverted easily as soon as the scripts are imported into the project.

I personally prefer having the js not in this library as long as we don't necessarily need it. It would bloat up the resulting web components and also would make the documentation more complex as to when you need to import the js-scripts, too and when you don't need them.

yes - currently there is no animation for the toggle-effect. but i think that's only a minor problem.

@langehm langehm merged commit 97ceb3c into beta May 28, 2024
@langehm langehm deleted the 41-sparkles-adding-business-hours-component branch May 28, 2024 08:49
@github-actions
Copy link

🎉 This PR is included in version 1.8.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ adding business hours component

3 participants