support PR comments

[SaulAryehKohn]

When a branch with a PR is rebased, the commits are orphaned and the comments from cml-send-comment are deleted. Is there a way to preserve them after a rebase? Alternatively, is there a way for cml-send-comment to comment on the PR itself, rather than a certain commit?

[0x2b3bfa0]

Is there a way to preserve them after a rebase?

None that is known to me, at least.

Alternatively, is there a way for cml-send-comment to comment on the PR itself, rather than a certain commit?

We still don't support this feature, and rely on commit comments to display the same information at the commit and the pull request levels.

[0x2b3bfa0]

@SaulAryehKohn & @saadlaaribi, feel free to request pull request comments (as opposed to commit comments) as a feature if you deem it useful.

[DavidGOrtega]

👋 @SaulAryehKohn cml-send-comment has an option update

Update the last CML comment (if any) instead of creating a new one

This feature will update always your last cml comment that ideally could be the very first commit in the branch. Not sure if it fits all your needs but maybe is worth a try

[SaulAryehKohn]

@SaulAryehKohn cml-send-comment has an option update

Update the last CML comment (if any) instead of creating a new one

This feature will update always your last cml comment that ideally could be the very first commit in the branch. Not sure if it fits all your needs but maybe is worth a try

👀 I will try that, thank you. I think all comments linked to commits are going to be wiped once the rebase alters the commit hash itself though. Stable solution will be to post the comment to the PR rather than to the commit. @0x2b3bfa0 could you please let me know how to formally request it as a feature?

[DavidGOrtega]

@SaulAryehKohn this feature might not be feasible. Not because its not possible in GH but maybe is not possible in other SCM. Just to clarify a bit more. The idea would be using the body of a PR instead?

[SaulAryehKohn]

@DavidGOrtega yes, a good reference is this action: https://github.com/EnricoMi/publish-unit-test-result-action which stays at the PR level but contains per-commit results

[0x2b3bfa0]

The idea would be using the body of a PR instead?

Either that, or just like cml send-comment but with pull request comments instead of commit comments. If I recall correctly it's supported on every provider: cml send-comment --commit-sha=a1b2c3d would use commit comments (that propagate to the pull request), and cml send-comment --pr=123 would use pull request comments. 🤔

@0x2b3bfa0 could you please let me know how to formally request it as a feature?

If you believe it would be an useful feature, please open a separate issue proposing it.

[DavidGOrtega]

Aha! PRs are sharing the issues API. I guess its doable.
--pr=123 should be inferred. Probably getting the PRs of a branch.