Automatically detect GitLab API base address #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidGOrtega
suggested changes
Apr 5, 2021
DavidGOrtega
suggested changes
Apr 5, 2021
Contributor
|
Looks good. Are you going to do a release of merge straight against master? @0x2b3bfa0 |
Member
Author
|
@DavidGOrtega, unless you want otherwise, I'll release v0.3.3 for consistency. |
DavidGOrtega
approved these changes
Apr 5, 2021
0x2b3bfa0
added a commit
that referenced
this pull request
Apr 5, 2021
* Automatically detect GitLab API base address (#464) * Automatically detect GitLab API base address * Apply review suggestions * Apply review suggestions * [create-pull-request] automated change (#461) Co-authored-by: DavidGOrtega <DavidGOrtega@users.noreply.github.com> * Bump is-svg from 4.2.1 to 4.2.2 (#454) Bumps [is-svg](https://github.com/sindresorhus/is-svg) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/sindresorhus/is-svg/releases) - [Commits](sindresorhus/is-svg@v4.2.1...v4.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump y18n from 4.0.0 to 4.0.1 (#462) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump patch to v0.3.4 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DavidGOrtega <DavidGOrtega@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix #463, where a GitLab instance served from a path different from the server root wouldn't be interpreted correctly. It feels a bit complicated for my taste, but should perform as expected.