Skip to content
This repository was archived by the owner on Mar 7, 2023. It is now read-only.

Conversation

@casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Aug 27, 2021

P.S. is there an easy way to propagate the relevant subset of this PR to other branches? The history looks like a mess. Would you like me to rebase & tidy the other branches in a follow-up issue? Long-term of course should be generated by https://github.com/iterative/example-repos-dev

@casperdcl casperdcl self-assigned this Aug 27, 2021
@casperdcl casperdcl requested review from daavoo and dberenbaum and removed request for daavoo August 27, 2021 13:33
@casperdcl casperdcl added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 27, 2021
@dberenbaum
Copy link
Contributor

Thanks, @casperdcl! All the formatting and copy edits look great!

I think using dvclive.get_step() with an infinite number of epochs seems kind of pointless, though, unless I'm missing something. I think we can either leave that out or stick with a finite number of epochs and fix it to match the expected resume functionality. The finite epochs seems useful since it's a more complex workflow, although it's hard to reproduce it in the other branch workflows. Maybe we can show finite epochs and note how dvclive makes it easy to coordinate with the epoch number in code?

P.S. is there an easy way to propagate the relevant subset of this PR to other branches? The history looks like a mess. Would you like me to rebase & tidy the other branches in a follow-up issue? Long-term of course should be generated by https://github.com/iterative/example-repos-dev

Yeah, this is a bit of a mess for now. I don't know an easy way to propagate to other branches, but feel free to

@dberenbaum
Copy link
Contributor

Oh, I just saw your suggestion with a branch for a fixed number of epochs. Nice idea. In that case, maybe we should drop dvclive.get_step() in this branch?

Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
@casperdcl casperdcl merged commit 1f558b0 into live Aug 27, 2021
@casperdcl casperdcl deleted the live-ulimit branch August 27, 2021 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use infinite loop instead of set number of epochs

3 participants