localfs: get_file: handle dirs like fsspec's localfs #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.64% // Head: 63.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 64.64% 63.60% -1.04%
==========================================
Files 25 25
Lines 1915 1918 +3
Branches 298 299 +1
==========================================
- Hits 1238 1220 -18
- Misses 623 645 +22
+ Partials 54 53 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
efiop
commented
Feb 20, 2023
| os.replace(tmp_file, rpath) | ||
|
|
||
| def get_file(self, rpath, lpath, callback=None, **kwargs): | ||
| if self.isdir(rpath): |
Contributor
Author
There was a problem hiding this comment.
This is wasteful though. Might want to just catch an exception below instead...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related iterative/dvc#9057