Skip to content

get/import-url: better handle remote:// notation errors #3236

@jorgeorpinel

Description

@jorgeorpinel

Working inside a fresh clone of https://github.com/iterative/dataset-registry 👍

$ dvc version
DVC version: 0.82.2
Python version: 3.7.6
Platform: Darwin-19.0.0-x86_64-i386-64bit
Binary: False
Package: brew
Cache: reflink - supported, hardlink - supported, symlink - supported

$ dvc get-url -v remote://storage/get-started/data.xml
ERROR: unexpected error - 'NoneType' object has no attribute 'repo'
------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/Cellar/dvc/0.82.2/libexec/lib/python3.7/site-packages/dvc/main.py", line 48, in main
    ret = cmd.run()
  File "/usr/local/Cellar/dvc/0.82.2/libexec/lib/python3.7/site-packages/dvc/command/get_url.py", line 17, in run
    Repo.get_url(self.args.url, out=self.args.out)
  File "/usr/local/Cellar/dvc/0.82.2/libexec/lib/python3.7/site-packages/dvc/repo/get_url.py", line 17, in get_url
    dep, = dependency.loads_from(None, [url])
  File "/usr/local/Cellar/dvc/0.82.2/libexec/lib/python3.7/site-packages/dvc/dependency/__init__.py", line 77, in loads_from
    ret.append(_get(stage, s, info))
  File "/usr/local/Cellar/dvc/0.82.2/libexec/lib/python3.7/site-packages/dvc/dependency/__init__.py", line 52, in _get
    remote = Remote(stage.repo, name=parsed.netloc)
AttributeError: 'NoneType' object has no attribute 'repo'
------------------------------------------------------------

Discord: https://discordapp.com/channels/485586884165107732/563406153334128681/670363031330619392

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugDid we break something?p2-mediumMedium priority, should be done, but less important

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions