repro: persisting outputs invalidates build cache #1877
Conversation
dvc/repo/reproduce.py
Outdated
There was a problem hiding this comment.
Why are we forcing everything though?
tests/test_repro.py
Outdated
There was a problem hiding this comment.
This is not testing running dvc run twice, which is where persist should make second run ignore build cache and actually run the command.
|
For the record: Discussed this privately. Need to undo the |
ghost
dismissed
efiop’s stale review
removed the code that was messing up with reproduce and left only run
tests/func/test_run.py
Outdated
There was a problem hiding this comment.
There shouldn't be a warning during the first run.
There was a problem hiding this comment.
@efiop , should we skip the overwrite stage file confirmation when outs-persist is used?
tests/func/test_run.py
Outdated
There was a problem hiding this comment.
should we test that that warning is not printed during the first run now? 🙂
There was a problem hiding this comment.
done, @efiop (sorry for such back-and-forth, I should've test it correctly beforehand 😅)
1 participant
Fix #1852