path_info: don't forget to override as_posix method #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
Unlike original implementation [1] that uses `str()` we actually need to use `fspath`, because we've overriden `__str__` method to return relative paths, which will break original `as_posix`. [1] https://github.com/python/cpython/blob/v3.7.0/Lib/pathlib.py#L692 Fixes treeverse#2483 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike original implementation [1] that uses
str()we actually needto use
fspath, because we've overriden__str__method to returnrelative paths, which will break original
as_posix.[1] https://github.com/python/cpython/blob/v3.7.0/Lib/pathlib.py#L692
Fixes #2483
Signed-off-by: Ruslan Kuprieiev ruslan@iterative.ai
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.