test: use helper remotes in TestCases #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Jan 14, 2020
efiop
reviewed
Jan 14, 2020
tests/func/test_data_cloud.py
Outdated
Comment on lines
258
to
260
Contributor
There was a problem hiding this comment.
Oh, this one doesn't match directly with LOCAL.get_url 🙁 I guess the line that uses dname down below is a pretty useless test, but just not to dive into it, we could simply wrap super().get_url here.
efiop
reviewed
Jan 14, 2020
tests/remotes.py
Outdated
skshetry
force-pushed
the
refactor-remotes-inherit
branch
3 times, most recently
from
3e9f3f6 to
69965e3
Compare
efiop
reviewed
Jan 14, 2020
skshetry
force-pushed
the
refactor-remotes-inherit
branch
from
9662f83 to
70df0d3
Compare
skshetry
commented
Jan 14, 2020
skshetry
force-pushed
the
refactor-remotes-inherit
branch
from
70df0d3 to
37b9d32
Compare
skshetry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I had in mind when refactoring #2878. This is still a work in progress at the moment though.
TODO
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏