Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jan 14, 2020

Related to #3087

Unblocking #3150

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@fabiosantoscode
Copy link
Contributor

Looks good to me!

@efiop efiop merged commit 0be0931 into iterative:master Jan 14, 2020
@efiop efiop deleted the 3087 branch January 14, 2020 23:06
@skshetry skshetry mentioned this pull request Jan 21, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants