s3: copy large objects without chunking #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing `boto3.s3.Client.Copy`, large files are chunked into multiple parts. The default chunk threshold and size is 8MB. This caused an issue when caching an object larger than 8M, where the original object had not been uploaded in multiple parts. The original object and the cached object would have different ETags, causing an exception. This fixes the issue by dynamically setting the chunk threshold to be one byte larger than the size of the original object therefore avoiding multipart copies. Fixes iterative#3174
|
Thank you @woodshop ! 🙏 |
skshetry
reviewed
Jan 18, 2020
| import logging | ||
| import os | ||
| import threading | ||
| from boto3.s3.transfer import TransferConfig |
There was a problem hiding this comment.
Shouldn't this import be inside _copy()?
There was a problem hiding this comment.
good catch @skshetry ! I think it's better to move inside indeed. Mind creating a PR for this?
There was a problem hiding this comment.
Totally missed that one! Thank you @skshetry !
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing
boto3.s3.Client.Copy, large files are chunked intomultiple parts. The default chunk threshold and size is 8MB. This
caused an issue when caching an object larger than 8M, where the
original object had not been uploaded in multiple parts. The original
object and the cached object would have different ETags, causing an
exception. This fixes the issue by dynamically setting the chunk
threshold to be one byte larger than the size of the original object
therefore avoiding multipart copies.
Fixes #3174
[:white_check_mark:] ❗ Have you followed the guidelines in the Contributing to DVC list?
[:white_check_mark:] 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
[:white_check_mark:] ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏