-
Couldn't load subscription status.
- Fork 1.3k
completion: autogenerate #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
completion: autogenerate #3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes iterative#2985 automatically generate bash completion
casperdcl
commented
May 31, 2020
casperdcl
commented
May 31, 2020
casperdcl
commented
May 31, 2020
d5e7cae to
597a809
Compare
597a809 to
387896d
Compare
skshetry
reviewed
Jun 1, 2020
|
ready for review now. The DeepSource test can be ignored ( |
1 task
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
efiop
reviewed
Jun 18, 2020
casperdcl
commented
Jun 19, 2020
|
This is great. Thank you @casperdcl ! |
|
Sure; feel free to add to #4070 with inevitable teething issues. |
2 tasks
casperdcl
added a commit
to casperdcl/dvc
that referenced
this pull request
Jun 21, 2020
- makes help output look the same as before iterative#3921
efiop
pushed a commit
that referenced
this pull request
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhances DVC
refactoring
Factoring and re-factoring
research
testing
Related to the tests and the testing infrastructure
ui
user interface / interaction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ye moste beautiful autogeneration of autocompletion
auto-generateuse iterative/shtab to generate completionscompletion/dvc.bashbased ondvc.clidvc completion [-s {bash,zsh}]subcommand[-f FILE] [{dir}]choices=(Required|Optional).DVC_FILEcustom completionadduse_dvc_compgen_dirsfor e.g. output paths ofget/importchoices=(Required|Optional).(FILE|DIR)custom completionintroduce consistency calling DVC-filesnot requiredtargetsand other filespaths?Required to choose between_dvc_compgen_filesand_dvc_compgen_DVCFilessnapbuild its own completionspotentially drop_dvc_compgen_filesforget/get-url/importshtabAPI offers separate completion of different args (i.e. don't complete url, but complete dirs for output path)completion/dvc.bashaltogethercompletion/dvc.zshtoomuch bash such python
follow-up tasks
add pre-commit hooknot needed as completions are dynamically generated nowtargets, other filespaths, and directoriesdirs