dvc: show "Having any troubles?" only on unexpected errors #4496
Merged
efiop merged 2 commits intotreeverse:masterfrom Aug 30, 2020
Merged
dvc: show "Having any troubles?" only on unexpected errors #4496efiop merged 2 commits intotreeverse:masterfrom
efiop merged 2 commits intotreeverse:masterfrom
Conversation
efiop
commented
Aug 30, 2020
Comment on lines
+28
to
29
| except DvcException: | ||
| logger.exception("failed to destroy DVC") |
Contributor
Author
There was a problem hiding this comment.
Doing this just to unify the behavior among all of the commands. We'll also need to reconsider(probably remove) Captain Obvious messages like this one, but that's too out-of-scope for this PR.
efiop
commented
Aug 30, 2020
| ret = 255 | ||
| except Exception: # noqa, pylint: disable=broad-except | ||
| logger.exception("unexpected error") | ||
| logger.info(FOOTER) |
Contributor
Author
There was a problem hiding this comment.
Might also consider moving it to error, but for now leaving as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4126
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏