dvc: override replace in HTTPURLInfo to include extra_parts #4517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The objective is to passtrough any parameter configured in http remotes. fixes #4508
Contributor
|
@MetalBlueberry thanks! :) 🙏 |
efiop
reviewed
Sep 2, 2020
Contributor
Author
|
I have one question, Should we include this change in URLInfo class instead of HTTPURLInfo? From my point of view, a replace method should only replace the given parameter and leave the others with the same value. In this case, the path. |
Contributor
remotes that use URLInfo don't actually have fragments/queries/params (at least from what I know), so I would rather not adjust it, unless someone has a use case. With HTTP it is pretty clear that it should be supported there. |
efiop
reviewed
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4508