ssh: install paramiko with invoke #4617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramiko has recently added support for `Match` paramiko/paramiko#717 which resulted in some users getting an import error about `invoke` module, as it is not a default dependecy for paramiko. @Pseudomanifold reported that installing `invoke` iterative#4589 worked for him, which means that this newly added paramiko feature works in his case. That feature seems to not affect configs without `Match`, so we could give this a try and install it by default. Our conda package will be updated during the next release. Fixes iterative#4589 Fixes iterative#4616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paramiko has recently added support for
Matchparamiko/paramiko#717
which resulted in some users getting an import error about
invokemodule, as it is not a default dependecy for paramiko.
@Pseudomanifold reported that installing
invoke#4589 worked forhim, which means that this newly added paramiko feature works in
his case. That feature seems to not affect configs without
Match,so we could give this a try and install it by default.
Our conda package will be updated during the next release.
Fixes #4589
Fixes #4616
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏