gdrive: revert back to the hack for uploading empty files #4632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
changed the title
efiop
force-pushed
the
fix-4593
branch
2 times, most recently
from
7b1e00d to
0e496d4
Compare
efiop
changed the title
efiop
commented
Sep 29, 2020
| from .test_api import all_clouds | ||
| all_clouds = [ | ||
| pytest.lazy_fixture(cloud) | ||
| for cloud in ["s3", "gs", "azure", "gdrive", "ssh", "http"] |
Contributor
Author
There was a problem hiding this comment.
Unfortunately gdrive is not setup yet on the GHA, we have it on our todo.
Contributor
Author
There was a problem hiding this comment.
Oops, forgot hdfs 🤦♂️ It is broken though on gha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need this hack, as
Uploaddoesn't support callbacks yet and wrapping an empty content into our own progress bar results in errors.Fixes #4593
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏