Skip to content

TestCmdCacheDir: roll back darwin skip #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

TestCmdCacheDir: roll back darwin skip #4673

merged 1 commit into from
Oct 21, 2020

Conversation

@pared
Copy link
Contributor

@pared pared commented Oct 7, 2020 •
edited
Loading

Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #4418

@pared pared force-pushed the 4418_test_cache branch 2 times, most recently from 43a4ab5 to b73497e Compare October 19, 2020 13:39
@pared pared marked this pull request as ready for review October 19, 2020 13:40
@pared pared changed the title [WIP] TestCmdCacheDir: roll back darwin skip TestCmdCacheDir: roll back darwin skip Oct 19, 2020
@pared pared changed the title TestCmdCacheDir: roll back darwin skip [WIP] TestCmdCacheDir: roll back darwin skip Oct 19, 2020
@pared
Copy link
Contributor Author

pared commented Oct 20, 2020 •
edited
Loading

The fails are related to the fact that in case of macos runner, mktemp() is creating temporary dir /var/.... /var is symlink to /private/var.
There seem to be some problem with evaluating the relative external cache paths, dvc is unable to makedirs cache subfolders for a relative path.

Wrapping the external cache path in os.path.realpath solves the problem.

I tried reproducing the problem on Linux, by reproducing workspace with symlinks to workspace directories but was unsuccessful. Seems like there is more to that than just symlink being in the path of the repo or external cache. I have tried debugging it via GitHub actions, but was unsuccessful. I am creating an issue to investigate it further.

EDIT
kudos @efiop for pointing out the how macos sets up some direcotries

@pared pared changed the title [WIP] TestCmdCacheDir: roll back darwin skip TestCmdCacheDir: roll back darwin skip Oct 20, 2020
@pared pared mentioned this pull request Oct 20, 2020
Closed
@pared pared requested a review from efiop October 20, 2020 10:32
@efiop efiop merged commit 33ece01 into iterative:master Oct 21, 2020
@pared pared deleted the 4418_test_cache branch January 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pared @efiop