dag: support output as target #4908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
Nov 19, 2020
efiop
force-pushed
the
fix-4904
branch
2 times, most recently
from
c289af6 to
fba0abf
Compare
efiop
commented
Nov 20, 2020
dvc/command/dag.py
Outdated
There was a problem hiding this comment.
This whole _transform method is only here because str(stage) is not using stage.addressing. Need to consider changing Stage.__str__ to it.
efiop
commented
Nov 20, 2020
dvc/command/dag.py
Outdated
Comment on lines
-99
to
-106
There was a problem hiding this comment.
Unrelated 🙁 , but we are gradually going away from KO errors like this in other places, so did it here too.
efiop
commented
Nov 20, 2020
dvc/repo/__init__.py
Outdated
Comment on lines
+555
to
+556
There was a problem hiding this comment.
Both of these will be very handy in #4847 and potentially other places. Plus we build some of them as a side-effect when validating the DAG, so we can cache them along the way.
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4904
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Docs already say that we can do that, so no need to update them.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏