Move tests requirements to test_requirements.txt #5674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan is to add dependabot to update those packages required for testing
skshetry
commented
Mar 23, 2021
Comment on lines
+117
to
+119
| tests_requirements = ( | ||
| Path("test_requirements.txt").read_text().strip().splitlines() | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Should we allow users to install with [tests] at all? I'd say that we should ask contributors to use -r dev_requirements.txt than using [tests] here but maybe it's just a matter of taste. Anyway, avoiding that change/discussion for now.
dependabot only understands pipfile/poetry lockfile/pip-tools and these requirements.txt. I'd prefer to keep these in setup.cfg but it doesn't support those yet.
efiop
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan is to add dependabot to update those packages required for testing, after this gets merged.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏