objects: hash_file: retrieve size from hash_info#6284
Merged
efiop merged 2 commits intotreeverse:masterfrom Jul 6, 2021
Merged
objects: hash_file: retrieve size from hash_info#6284efiop merged 2 commits intotreeverse:masterfrom
efiop merged 2 commits intotreeverse:masterfrom
Conversation
Contributor
Author
|
Command (100 x 1kb): Master: The difference highly depends on the number of files, since for each file we perform an API call. |
efiop
reviewed
Jul 5, 2021
isidentical
force-pushed
the
speed-up-size-computing
branch
from
47d77c4 to
8707aaa
Compare
efiop
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6283. I am still not quite sure to whether we should keep
getsize()logic at all, or not since this information should be propagated from an upper level (e.g staging, in this case fills HashInfos). Lazily retrieving this is very bad for performance, especially when you have a lot of files.