Change ui message for the updater #6437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Aug 16, 2021
| current=self.current, | ||
| latest=latest, | ||
| message = self._get_message(latest, pkg=pkg) | ||
| return ui.error_write(message, styled=True) |
Collaborator
Author
There was a problem hiding this comment.
Changed the message to output to the stderr.
efiop
approved these changes
Aug 16, 2021
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Looks great! 💅
Btw, we don't have any mention of this in docs that we need to update, right?
Collaborator
Author
No, we don't have any. And, I don't think this needs a mention. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
On top of #6247.
Related to #5912.
Screenshots
I still have some doubts about the link in blue, could also color it in yellow. Please see if the messages are clearer too.
Also note that the ui messages only appear in
dvc version.