Skip to content

http: explicitly retry all http-related errors #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efiop merged 1 commit into from
Oct 2, 2021
Merged

http: explicitly retry all http-related errors #6728

efiop merged 1 commit into from
Oct 2, 2021

Conversation

@isidentical
Copy link
Contributor

@isidentical isidentical commented Oct 2, 2021

Beside the server-side errors like timeouts, also retry stuff that is happening on the client (e.g internet connection drop for a second).

@isidentical isidentical added the fs: http Related to the HTTP filesystem label Oct 2, 2021
@isidentical isidentical requested a review from efiop October 2, 2021 17:13
@isidentical isidentical self-assigned this Oct 2, 2021
@isidentical isidentical requested a review from a team as a code owner October 2, 2021 17:13
@isidentical
Copy link
Contributor Author

isidentical commented Oct 2, 2021

Something I noticed while trying the dvc get example. Not sure if there is an easy way to imitate this on the tests, so not adding something for now.

efiop
efiop approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🔥

@efiop efiop merged commit e53d390 into treeverse:master Oct 2, 2021
@efiop efiop added the enhancement Enhances DVC label Oct 2, 2021
@skshetry
Copy link
Collaborator

skshetry commented Oct 3, 2021 •
edited
Loading

How does this work for put_file? We should not be retrying on PUT/POST, as it is not idempotent.

Also what happens during fs.open, if it times out in the middle?

@iesahin iesahin mentioned this pull request Oct 27, 2021
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@isidentical isidentical

Labels

enhancement Enhances DVC fs: http Related to the HTTP filesystem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isidentical @skshetry @efiop