dvcfs: handle repo root #7408
Merged
dvcfs: handle repo root #7408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Feb 21, 2022
Comment on lines
+22
to
+24
| def test_get_key(tmp_dir, dvc, path, key): | ||
| fs = DvcFileSystem(repo=dvc) | ||
| assert fs._get_key(path) == key |
Contributor
Author
There was a problem hiding this comment.
As discussed before, a bit of an overkill to use real dvc in unit tests, but still kept using them in this one for simplicity. #7408 is a start to moving to fsspec, where we will scrap most of these tests for something better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7407