hdfs: Fix _strip_protocol and _checksum
#7563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match behavior previous to #6946
daavoo
force-pushed
the
fix-hdfs-external-dep
branch
from
38809a8 to
770db1f
Compare
daavoo
commented
Apr 11, 2022
Contributor
Author
There was a problem hiding this comment.
@efiop Not sure how to test because the issue happens when calling the exists of the underlying HadoopFileSystem. However we are monkey-patching it in dvc-hdfs, making test pass regardless of this changes or not:
efiop
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match behavior previous to #6946
Closes #7561