Fix skips #1
Merged
Fix skips #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
May 4, 2022
Contributor
Author
daavoo
left a comment
daavoo
left a comment
There was a problem hiding this comment.
test_import_dir fails because of how FakeHadoopFS resolves the path in:
@efiop Is there a reason for not using actual HadoopFS (installation issues?) . Using the fake fs also hid the bug in iterative/dvc#7563
Contributor
|
@daavoo real hdfs takes a while to install and doesn't work anywhere except for linux (mac runners don't have docker). Seems like iterative/dvc#7563 should be tested with a unit test. |
Fix unintentional skips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.