data status: optimize printing status list #8049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--untracked-files` and `--unchanged` coupled with `--granular` puts a lot of stress on `show_status`. Currently, with those options, dvc spends ~26s on `_show_status` function. Unhappy with the above result, I looked into improving the situation with `console.out`. It did reduce that to 9s but it still felt like a lot. Then I dropped to good old colorama, which dropped to 3s(term)/1.24(redirected). I tested with buffering output which dropped this further to ~600ms(term)/~100ms(redirected). This may seem like premature optimization, but this was preventing me from figuring out perf issues in granular outputs, and I believe the user should not be penalize for using feature that we already offer.
efiop
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--untracked-filesand--unchangedcoupled with--granularputs a lot of stress on
_show_status. Currently, with those options,dvc spends ~26s on
_show_statusfunction.Unhappy with the above result, I looked into improving the situation by using
console.out(highlight=False). It did reduce that to 9s but it still felt like a lot.Then I dropped to good old colorama, which dropped to 3s(term)/1.24(redirected).
I tested with buffering output which dropped this further to ~600ms(term)/~100ms(redirected).
Note that this result was in VSCode which is slower than other terminals.
In gnome-terminal, I get about 175ms, and in kitty, it is around 125ms (undirected).
This may seem like premature optimization, but this was preventing me
from figuring out perf issues in granular outputs, and I believe the
users should not be penalized for using features that we already offer.