Skip to content

Conversation

@karajan1001
Copy link
Contributor

fix: #8014

ERROR: Invalid experiment '{entry.stash_rev[:7]}'.

This happens when the queue task failed from a scm error.

{"exc_type": "GitMergeError", "exc_message": ["Cannot fast-forward HEAD
to '05100047a341f2fa4a02421289d48f84d8c45e86'"], "exc_module": "dvc.scm"}.

And the failed task neither create a infofile nor create a fail_stash.

  1. Didn't raise DvcException if no infofile found for failed tasks.
    (success tasks still raise it)
  2. Add a new unit test for this.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@karajan1001 karajan1001 added A: experiments Related to dvc exp bugfix fixes bug A: task-queue labels Aug 5, 2022
@karajan1001 karajan1001 requested a review from pmrowla August 5, 2022 13:20
@karajan1001 karajan1001 requested a review from a team as a code owner August 5, 2022 13:20
@pmrowla
Copy link
Contributor

pmrowla commented Aug 7, 2022

@karajan1001 this needs a rebase

fix: treeverse#8014
> ERROR: Invalid experiment '{entry.stash_rev[:7]}'.

This happens when the queue task failed from a scm error.

{"exc_type": "GitMergeError", "exc_message": ["Cannot fast-forward HEAD
to '05100047a341f2fa4a02421289d48f84d8c45e86'"], "exc_module": "dvc.scm"}.

And the failed task neither create a infofile nor create a fail_stash.

1. Didn't raise DvcException if no infofile found for failed tasks.
   (success tasks still raise it)
2. Add a new unit test for this.
@pmrowla pmrowla merged commit 306456d into treeverse:main Aug 8, 2022
@karajan1001 karajan1001 deleted the fix8014 branch August 8, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: experiments Related to dvc exp bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc queue: unexpected behaviour

2 participants