Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 4, 2022


Wait for release

@daavoo daavoo changed the title Dvclive 1.0 DVCLive 1.0 Nov 4, 2022
@daavoo daavoo requested a review from dberenbaum November 4, 2022 17:20
@dberenbaum
Copy link
Contributor

Technically, there are breaking changes to DVC here like dropping --live altogether. We could also consider keeping DVC pinned to a pre-1.0 version of DVCLive for now, but maybe that's more confusing. Thoughts?

@daavoo
Copy link
Contributor Author

daavoo commented Nov 4, 2022

Technically, there are breaking changes to DVC here like dropping --live altogether. We could also consider keeping DVC pinned to a pre-1.0 version of DVCLive for now, but maybe that's more confusing. Thoughts?

I would prefer to violate the semver laws in this case.
It is just better UX and the flag has been hidden for a while now.

I take full responsibility if the semver police show up 👼

side note. TBH, I feel like we should be releasing major versions (meaning breaking changes) more frequently on DVC (or just use another versioning schema).

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dropping dvc exp init --live is not what we should be doing (at least for now, even though nobody may be using it).

Edit: see the comment there, we just need to update the paths for it instead.

@daavoo daavoo marked this pull request as ready for review November 5, 2022 10:17
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 94.31% // Head: 94.30% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5d9e725) compared to base (240f0eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8532      +/-   ##
==========================================
- Coverage   94.31%   94.30%   -0.01%     
==========================================
  Files         431      429       -2     
  Lines       32826    32670     -156     
  Branches     4582     4562      -20     
==========================================
- Hits        30959    30809     -150     
+ Misses       1448     1446       -2     
+ Partials      419      415       -4     
Impacted Files Coverage Δ
dvc/commands/stage.py 72.11% <ø> (-1.04%) ⬇️
dvc/env.py 100.00% <ø> (ø)
dvc/repo/reproduce.py 96.00% <ø> (+0.61%) ⬆️
dvc/schema.py 100.00% <ø> (ø)
dvc/stage/loader.py 99.20% <ø> (ø)
dvc/stage/monitor.py 88.88% <ø> (-0.27%) ⬇️
dvc/stage/params.py 100.00% <ø> (ø)
tests/func/experiments/test_init.py 100.00% <ø> (ø)
tests/unit/command/test_run.py 100.00% <ø> (ø)
tests/unit/command/test_stage.py 100.00% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo enabled auto-merge (rebase) November 5, 2022 12:43
@dberenbaum
Copy link
Contributor

Looks like some of the tests aren't finding dvclive 1.0?

@dberenbaum
Copy link
Contributor

@efiop @iterative/dvc The goal is to get this merged and have a release out before GitHub Universe on Wednesday (November 9th). @daavoo and I are out this week. Could you please ensure a release gets out before then?

Thank you 🙏

@skshetry
Copy link
Collaborator

skshetry commented Nov 6, 2022

DVCLive's version should have been 1.0.0 instead of just 1.0 which is causing the failure.

@skshetry
Copy link
Collaborator

skshetry commented Nov 6, 2022

libssh is no longer bundled with pygit2, which is why the CI is broken.

@daavoo daavoo merged commit 2c3956b into main Nov 7, 2022
@daavoo daavoo deleted the dvclive-1.0 branch November 7, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exp init: update paths for dvclive 1.0 restructure

3 participants