exp run: git add param files that will be modified. #9305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
7842-dvc-exp-run-queue-deleting-file-paramsyaml-for-each-command-call
branch
from
58ecdf3 to
6fdb7f5
Compare
daavoo
commented
Apr 4, 2023
| "Adding it to git.", | ||
| path, | ||
| ) | ||
| repo.scm.add([path]) |
Contributor
Author
There was a problem hiding this comment.
I thought it was simpler to be opinionated for this particular case instead of trying to handle arbitrary untracked files.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9305 +/- ##
=======================================
Coverage 92.94% 92.95%
=======================================
Files 459 459
Lines 37112 37123 +11
Branches 5342 5344 +2
=======================================
+ Hits 34493 34506 +13
+ Misses 2089 2086 -3
- Partials 530 531 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dberenbaum
approved these changes
Apr 4, 2023
pmrowla
approved these changes
Apr 5, 2023
Only if they are currently untracked and `--temp` or `--queue` is passed. Closes #7842
daavoo
deleted the
7842-dvc-exp-run-queue-deleting-file-paramsyaml-for-each-command-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only if they are currently untracked.
Closes #7842