Skip to content

Conversation

@pacifikus
Copy link
Contributor

Closes #112

PR PR in dvc.org: iterative/dvc.org#2748

@daavoo daavoo self-requested a review August 23, 2021 20:43
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @pacifikus !

Just one minor comment regarding loader_key prefix

Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
@daavoo
Copy link
Contributor

daavoo commented Aug 24, 2021

Thanks for the contribution @pacifikus !

Just one minor comment regarding loader_key prefix

Forgot to comment that tests should be updated to match the new behavior

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #139 (a23e42e) into master (3286543) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head a23e42e differs from pull request most recent head 59c88fa. Consider uploading reports for the commit 59c88fa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   90.43%   90.28%   -0.15%     
==========================================
  Files          13       13              
  Lines         324      319       -5     
==========================================
- Hits          293      288       -5     
  Misses         31       31              
Impacted Files Coverage Δ
dvclive/catalyst.py 100.00% <100.00%> (ø)
dvclive/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3286543...59c88fa. Read the comment docs.

@daavoo daavoo merged commit 138debe into iterative:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integrations: Catalyst

3 participants