Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Sep 13, 2022

No description provided.

avKostanov and others added 2 commits September 13, 2022 11:11
To reproduce DeprecationWarning, run

from logger import DvcLiveLogger
from pytorch_lightning import Trainer

import dvclive
import pytorch_lightning as pl
logger = DvcLiveLogger(
    path='./logs'
)

trainer = Trainer(
    logger=logger,
    accelerator='gpu'
)
print(dvclive.__version__)
print(pl.__version__)

This fixes warnings

pre-commit
@daavoo daavoo mentioned this pull request Sep 13, 2022
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Base: 94.81% // Head: 94.81% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (73dfd5b) compared to base (cbd5ea6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   94.81%   94.81%   -0.01%     
==========================================
  Files          34       34              
  Lines        1524     1523       -1     
  Branches      166      166              
==========================================
- Hits         1445     1444       -1     
  Misses         58       58              
  Partials       21       21              
Impacted Files Coverage Δ
src/dvclive/lightning.py 89.74% <100.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit 72ee55f into main Sep 13, 2022
@daavoo daavoo deleted the bump-lightning branch September 13, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants