Skip to content

Conversation

@dtrifiro
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Base: 95.07% // Head: 93.20% // Decreases project coverage by -1.86% ⚠️

Coverage data is based on head (1b30b59) compared to base (afa21a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   95.07%   93.20%   -1.87%     
==========================================
  Files          35       35              
  Lines        1664     1664              
  Branches      185      185              
==========================================
- Hits         1582     1551      -31     
- Misses         61       93      +32     
+ Partials       21       20       -1     
Impacted Files Coverage Δ
src/dvclive/keras.py 100.00% <100.00%> (ø)
src/dvclive/live.py 96.02% <100.00%> (ø)
src/dvclive/lgbm.py 28.57% <0.00%> (-71.43%) ⬇️
tests/test_lgbm.py 48.78% <0.00%> (-51.22%) ⬇️
src/dvclive/dvc.py 19.35% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dtrifiro dtrifiro self-assigned this Sep 27, 2022
@dtrifiro
Copy link
Contributor Author

Not sure what's going on, but this is the error (linting session):

nox > safety check --full-report
Unhandled exception happened: 'catalyst'

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can also remove the 3.10.6 pin on CI as the mypy release is supposed to fix the issue

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Sep 27, 2022

@daavoo the safety session is failing because of a catalyst[dev] dependency (sphinx) with a security vulnerability 🤦‍♀️. I see that catalyst is pinned: catalyst<=21.12, do you know why?

@daavoo
Copy link
Contributor

daavoo commented Sep 28, 2022

@daavoo the safety session is failing because of a catalyst[dev] dependency (sphinx) with a security vulnerability 🤦‍♀️. I see that catalyst is pinned: catalyst<=21.12, do you know why?

I believe because of this #219

@daavoo
Copy link
Contributor

daavoo commented Sep 28, 2022

@daavoo the safety session is failing because of a catalyst[dev] dependency (sphinx) with a security vulnerability 🤦‍♀️. I see that catalyst is pinned: catalyst<=21.12, do you know why?

The vulnerability appears to also affect the latest version so the pin was not really the problem (anyway it is good to update our integration)

@daavoo daavoo merged commit b2240f2 into iterative:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants