Skip to content

report: Handle custom names used in sklearn_plots. #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

report: Handle custom names used in sklearn_plots. #372

merged 1 commit into from
Nov 30, 2022

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 30, 2022

Closes #370

@daavoo daavoo added bugfix A: report Area: `live.make_report` labels Nov 30, 2022
@daavoo daavoo self-assigned this Nov 30, 2022
@daavoo daavoo linked an issue Nov 30, 2022 that may be closed by this pull request
log_sklearn_plot: custom names break make_report #370
Closed
@daavoo daavoo requested a review from dberenbaum November 30, 2022 17:17
@daavoo daavoo marked this pull request as draft November 30, 2022 17:19
daavoo
daavoo commented Nov 30, 2022
View reviewed changes
Copy link
Contributor Author

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed one of the cases in the issue

@daavoo daavoo removed the request for review from dberenbaum November 30, 2022 17:20
@daavoo daavoo force-pushed the 370-log_sklearn_plot-custom-names-break-make_report branch from 86677dd to 17e7e7c Compare November 30, 2022 17:35
@daavoo daavoo marked this pull request as ready for review November 30, 2022 17:35
@dberenbaum
Copy link

dberenbaum commented Nov 30, 2022

I missed one of the cases in the issue

Sorry, I should have made more clear that those were 2 separate bugs.

@daavoo daavoo force-pushed the 370-log_sklearn_plot-custom-names-break-make_report branch from 17e7e7c to ab15a36 Compare November 30, 2022 18:05
@daavoo daavoo requested a review from dberenbaum November 30, 2022 18:05
@daavoo
Copy link
Contributor Author

daavoo commented Nov 30, 2022 •
edited
Loading

I missed one of the cases in the issue

Sorry, I should have made more clear that those were 2 separate bugs.

Both should be fixed now in the P.R.

dberenbaum
dberenbaum reviewed Nov 30, 2022
View reviewed changes
@daavoo daavoo force-pushed the 370-log_sklearn_plot-custom-names-break-make_report branch from 8334420 to e2706f6 Compare November 30, 2022 18:50
@daavoo daavoo requested a review from dberenbaum November 30, 2022 18:50
@daavoo
report: Handle custom names used in sklearn_plots.
31ab286 
Closes #370

Co-authored-by: Dave Berenbaum <dave@iterative.ai>
@daavoo daavoo force-pushed the 370-log_sklearn_plot-custom-names-break-make_report branch from e2706f6 to 31ab286 Compare November 30, 2022 19:06
@daavoo daavoo merged commit e9ed5a0 into main Nov 30, 2022
@daavoo daavoo deleted the 370-log_sklearn_plot-custom-names-break-make_report branch November 30, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dberenbaum dberenbaum dberenbaum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daavoo daavoo

Labels

A: report Area: `live.make_report` bugfix

Projects

DVC
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

log_sklearn_plot: custom names break make_report

3 participants

@daavoo @dberenbaum