chore(setup): migrate to pyproject, add version #589
Conversation
shcheklein
force-pushed
the
migrate-to-pyproject
branch
from
29c55cd to
ac868e2
Compare
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
- Coverage 96.20% 96.11% -0.10%
==========================================
Files 43 44 +1
Lines 2874 2881 +7
Branches 240 240
==========================================
+ Hits 2765 2769 +4
- Misses 65 68 +3
Partials 44 44
☔ View full report in Codecov by Sentry. |
daavoo
left a comment
daavoo
left a comment
There was a problem hiding this comment.
Needed to do dynamic checks (e.g. check that version is correct in the callback) and overall it's expected that packages have it.
See #359 (comment) .
Do you have any reason not to use it in the callback?
I prefer that over adding the version, but I have no strong opinion.
Also, don't have a strong opinion. I think it can be convenient since people seems to expect it still and most (?) of the package provide it. But I can remove it (I assume toml migration is still meaningful for us) |
Migrate setup to
pyproject.toml. Adds__version__to the package. Needed to do dynamic checks (e.g. check that version is correct in the callback) and overall it's expected that packages have it.❗ I have followed the Contributing to DVCLive
guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏