Skip to content

Conversation

@alex000kim
Copy link
Contributor

@alex000kim alex000kim commented Jan 26, 2023

Addresses @daavoo's TODO from another PR:
#161 (comment)

@shcheklein
Copy link
Member

@alex000kim does it close some ticket? could you please add a bit more details to understand the context better ... may be screenshot of screen recording would be also great, to help review this.

@alex000kim
Copy link
Contributor Author

@shcheklein good point. I updated the description (not sure what you mean by a screen recording)

Comment on lines +175 to +176
" live.summary[\"base_lr\"] =base_lr\n",
" live.make_summary()\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex000kim any reason to not make this a parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean via .log_param()?
I can update that, but for this one, I simply followed the docs examples for fastai:
https://dvc.org/doc/dvclive/api-reference/ml-frameworks/fastai#examples
image

@daavoo daavoo merged commit f597095 into example-get-started-cv Jan 30, 2023
@daavoo daavoo deleted the eval-metrics-notebook branch January 30, 2023 16:13
daavoo pushed a commit that referenced this pull request Jan 31, 2023
* add results/evaluate metrics

* clear notebook
daavoo added a commit that referenced this pull request Feb 1, 2023
* Add example-get-started-cv.

Co-authored-by: Alex Kim <alex000kim@gmail.com>

* Updates to script and notebook

* Update generate.sh

* Add run-studio-experiment.yml

* Updates from Review

* newline

* Add eval metrics notebook (#162)

* add results/evaluate metrics

* clear notebook

* move data pull

* notebook updates

* update params

* Update log_params

* fix evaluate results dir

* cleanup

* Rename to example-get-started-experiments

* Update README

* run generate.sh

* Add root .devcontainer.json

* Update README

* Delete .devconainer.json

* full run. update README

* Update aws role in github workflow

* Use base_lr from notebook iterations

* Add environment: cloud

* Update lates requirements

* format READMES

* format generate.sh

* fix typo

---------

Co-authored-by: Alex Kim <alex000kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants