Skip to content

Conversation

@mjasion
Copy link
Contributor

@mjasion mjasion commented Jul 13, 2023

Waits for #21

Copying @omesser comment from #123

I recommend the approach where for such things we provide a full name override but the default behavior is to calculate the name in the chart, so the fullnameOverride value is either commented out (@jesper7 will hate it) or just empty string.

We can create a helper template (in _helpers.tpl) along those lines:

{{- define "studio.rayOperator.fullname" -}}
{{- if .Values.rayOperator.fullnameOverride -}}
{{- .Values.rayOperator.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-ray-operator" .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

and use in values via {{ include "studio.rayOperator.fullname" . }}

Whenever we have such if-else boilerplate to calc a name or field - we can move it to a helper value to keep the resource charts clean and we would probably end up reusing a lot of those.

don't have a strong opinion about ray vs rayOperator but since the actual ray cluster is a CRD and not the operator that's installed in the chart it might be less confusing to make the distinction obvious via naming, harming brevity

@mjasion mjasion requested a review from jesper7 July 13, 2023 15:17
@mjasion mjasion self-assigned this Jul 13, 2023
@mjasion mjasion marked this pull request as draft July 13, 2023 15:18
@mjasion mjasion force-pushed the remove_redis_fullnameoverride branch from eed66bc to 2593118 Compare July 14, 2023 16:09
@shcheklein
Copy link
Contributor

@mjasion is still relevant?

@0x2b3bfa0
Copy link
Contributor

No longer relevant in the short term; opened #619 for tracking.

@0x2b3bfa0 0x2b3bfa0 closed this May 11, 2025
@0x2b3bfa0 0x2b3bfa0 deleted the remove_redis_fullnameoverride branch May 11, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants